Fix: Set air block state when breaking a block #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes the dirt block particles when breaking a block
|
I've imported the BlockState class in case there would be a change in the air block's block state. Not sure if it's that important, maybe a constant 0 would be enough as well |
|
These are the sounds and particles being broadcasted. It should be not air, It should be the block broken |
|
So it should be the old block's state id rather than the new one's? |
Of course, Air has no sound and no Breaking Particles. We want to use the ID of the broken block |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The server broadcasted a block breaking event with the block state
11. Which meant that it set the new block's (air block)state to 11, which isn't a valid state for that block.
Testing
Place a block, which is not dirt or grass and then break it, no more dual particles
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmtcargo clippy